wgtmac commented on code in PR #646:
URL: https://github.com/apache/iceberg-cpp/pull/646#discussion_r3247384124
##########
src/iceberg/catalog/rest/auth/auth_session.cc:
##########
@@ -44,6 +51,183 @@ class DefaultAuthSession : public AuthSession {
std::unordered_map<std::string, std::string> headers_;
};
+/// \brief OAuth2 session with automatic token refresh.
+class OAuth2AuthSession : public AuthSession,
+ public
std::enable_shared_from_this<OAuth2AuthSession> {
+ public:
+ struct Config {
+ std::string token_endpoint;
+ std::string client_id;
+ std::string client_secret;
+ std::string scope;
+ bool keep_refreshed;
+ };
+
+ /// \brief Create an OAuth2 session and optionally schedule refresh.
+ static std::shared_ptr<OAuth2AuthSession> Create(
+ const OAuthTokenResponse& initial_token, Config config, HttpClient&
client) {
+ auto session = std::shared_ptr<OAuth2AuthSession>(
+ new OAuth2AuthSession(std::move(config), client));
+ session->SetInitialToken(initial_token);
+ return session;
+ }
+
+ Status Authenticate(std::unordered_map<std::string, std::string>& headers)
override {
+ std::shared_lock lock(mutex_);
+ for (const auto& [key, value] : headers_) {
+ headers.insert_or_assign(key, value);
Review Comment:
Use `try_emplace` here so a request-specific `Authorization` header can win,
matching `DefaultAuthSession` and Java’s `putIfAbsent` behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
