talatuyarer commented on code in PR #16268:
URL: https://github.com/apache/iceberg/pull/16268#discussion_r3228404182
##########
flink/v2.1/flink/src/test/java/org/apache/iceberg/flink/source/reader/TestColumnStatsWatermarkExtractor.java:
##########
@@ -61,6 +61,13 @@ public class TestColumnStatsWatermarkExtractor {
required(3, "long_column", Types.LongType.get()),
required(4, "string_column", Types.StringType.get()));
+ // Separate schema for nanosecond columns: TIMESTAMP_NANO requires table
format v3, which the
+ // HadoopTableExtension above does not provision. Tested via constructor
preconditions only.
+ private static final Schema NANO_SCHEMA =
+ new Schema(
+ required(1, "timestamp_ns_column",
Types.TimestampNanoType.withoutZone()),
+ required(2, "timestamptz_ns_column",
Types.TimestampNanoType.withZone()));
Review Comment:
This test doesn't use the `HadoopTableExtension`. It writes Parquet directly
via GenericFileWriterFactory into a `@TempDir` and constructs
`BaseFileScanTask` manually. Therefore, the catalog and table created by the
extension are unused. That's why I created a separate schema. However, I can
merge it into the main schema if you prefer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
