talatuyarer commented on code in PR #16268:
URL: https://github.com/apache/iceberg/pull/16268#discussion_r3227867117
##########
flink/v2.1/flink/src/test/java/org/apache/iceberg/flink/sink/shuffle/TestSortKeySerializerPrimitives.java:
##########
@@ -54,6 +54,9 @@ protected SortOrder sortOrder() {
.sortBy(Expressions.bucket("uuid_field", 16), SortDirection.ASC,
NullOrder.NULLS_FIRST)
.sortBy(Expressions.hour("ts_with_zone_field"), SortDirection.ASC,
NullOrder.NULLS_FIRST)
.sortBy(Expressions.day("ts_without_zone_field"), SortDirection.ASC,
NullOrder.NULLS_FIRST)
+ .asc("ts_ns_with_zone_field")
Review Comment:
The line below, `Expressions.hour("ts_ns_without_zone_field")`, covers
transforms to int, hitting the existing INTEGER case. The
`.asc("ts_ns_with_zone_field")` line is what tests the new raw-long
`TIMESTAMP_NANO` case. Without it, the new switch branch wouldn't be exercised
by these tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
