huaxingao commented on code in PR #16287:
URL: https://github.com/apache/iceberg/pull/16287#discussion_r3221361833


##########
.github/workflows/kafka-connect-cve-scan.yml:
##########
@@ -27,78 +27,37 @@ on:
     - '2.*'
     tags:
     - 'apache-iceberg-**'
-  pull_request:

Review Comment:
    I think we need to fail on PR and be informational on main. I actually 
found my way to this PR *because* the post-merge scan on #16279 failed, and I'd 
rather have seen those CVEs at review time than after they landed on main.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to