danielcweeks commented on code in PR #16174: URL: https://github.com/apache/iceberg/pull/16174#discussion_r3196626526
########## core/src/main/java/org/apache/iceberg/RelativePathUtil.java: ########## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg; + +import org.apache.iceberg.relocated.com.google.common.base.Preconditions; + +class RelativePathUtil { Review Comment: I think we need to change this to something more like `LocationUtils`, which unfortunately already exists under `org.apache.iceberg.util`. There's only one method in that class, so maybe ~we deprecate that and move it here to preserve the package private access for now~ add this functionality there and either leave it protected until we use it or just expose it as public. We should avoid making this purely about relative operations and also we've tried to standardize more around `location` than `path` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
