wgtmac commented on code in PR #631:
URL: https://github.com/apache/iceberg-cpp/pull/631#discussion_r3189767911
##########
src/iceberg/test/CMakeLists.txt:
##########
@@ -47,6 +47,10 @@ function(add_iceberg_test test_name)
if(ARG_USE_BUNDLE)
target_link_libraries(${test_name} PRIVATE iceberg_bundle_static
GTest::gmock_main)
+ elseif(ARG_USE_DATA)
+ target_link_libraries(${test_name}
+ PRIVATE
"$<IF:$<TARGET_EXISTS:iceberg_data_static>,iceberg_data_static,iceberg_data_shared>"
+ GTest::gmock_main)
Review Comment:
```suggestion
target_link_libraries(${test_name} PRIVATE iceberg_data_static
GTest::gmock_main)
```
nit: let's fix it either by using static libraries here or fix other
branches to add the same detection.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
