wgtmac commented on code in PR #631:
URL: https://github.com/apache/iceberg-cpp/pull/631#discussion_r3182607860
##########
src/iceberg/meson.build:
##########
@@ -184,8 +187,35 @@ iceberg_dep = declare_dependency(
compile_args: iceberg_interface_args,
)
meson.override_dependency('iceberg', iceberg_dep)
+
+iceberg_data_deps = [iceberg_dep, croaring_dep]
+iceberg_data_lib = library(
+ 'iceberg_data',
+ sources: iceberg_data_sources,
+ dependencies: iceberg_data_deps,
+ include_directories: iceberg_include_dir,
+ install: true,
+ gnu_symbol_visibility: 'inlineshidden',
+ cpp_shared_args: ['-DICEBERG_DATA_EXPORTING'],
+ cpp_static_args: ['-DICEBERG_DATA_STATIC'],
+)
+
+iceberg_data_interface_args = []
+if get_option('default_library') != 'shared'
Review Comment:
Use `== 'static'` here, like `iceberg_rest`. With `--default-library=both`,
consumers can link the shared `iceberg_data` library but still get
`ICEBERG_DATA_STATIC`, so Windows builds won't import the DLL symbols correctly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
