toutane commented on PR #2395:
URL: https://github.com/apache/iceberg-rust/pull/2395#issuecomment-4378130525
Hey, one thing worth considering imho, he root issue is in
`TableMetadataBuilder::build()`, which uses `Utc::now()` when no timestamp is
set explicitly. An alternative that fixes it at the source rather than relaxing
the assertion:
```rust
self.metadata.last_updated_ms = self.last_updated_ms.unwrap_or_else(|| {
chrono::Utc::now()
.timestamp_millis()
.max(self.metadata.last_updated_ms + 1)
});
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
