huaxingao commented on code in PR #14297:
URL: https://github.com/apache/iceberg/pull/14297#discussion_r3185548545
##########
spark/v4.1/spark/src/main/java/org/apache/iceberg/spark/SparkWriteConf.java:
##########
@@ -724,4 +734,23 @@ public DeleteGranularity deleteGranularity() {
.defaultValue(DeleteGranularity.FILE)
.parse();
}
+
+ public boolean shredVariants() {
+ return confParser
+ .booleanConf()
+ .option(SparkWriteOptions.SHRED_VARIANTS)
+ .sessionConf(SparkSQLProperties.SHRED_VARIANTS)
+ .tableProperty(TableProperties.PARQUET_VARIANT_SHRED)
+ .defaultValue(TableProperties.PARQUET_VARIANT_SHRED_DEFAULT)
+ .parse();
+ }
+
+ public int variantInferenceBufferSize() {
+ return confParser
+ .intConf()
Review Comment:
should we add `.option(...)` too? Right now `shredVariants()` can be
overridden per-write but `variantInferenceBufferSize()` can't.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
