huaxingao commented on code in PR #14297:
URL: https://github.com/apache/iceberg/pull/14297#discussion_r3185294097
##########
parquet/src/main/java/org/apache/iceberg/parquet/ParquetFormatModel.java:
##########
@@ -41,38 +45,61 @@
import org.apache.iceberg.relocated.com.google.common.base.Preconditions;
import org.apache.iceberg.relocated.com.google.common.collect.ImmutableMap;
import org.apache.parquet.schema.MessageType;
+import org.apache.parquet.schema.Type;
public class ParquetFormatModel<D, S, R>
extends BaseFormatModel<D, S, ParquetValueWriter<?>, R, MessageType> {
+ public static final String SHRED_VARIANTS_KEY =
TableProperties.PARQUET_VARIANT_SHRED;
+ public static final String VARIANT_BUFFER_SIZE_KEY =
TableProperties.PARQUET_VARIANT_BUFFER_SIZE;
+ public static final int DEFAULT_BUFFER_SIZE =
TableProperties.PARQUET_VARIANT_BUFFER_SIZE_DEFAULT;
Review Comment:
nit: Do we need to add these constants? Shall we use
TableProperties.PARQUET_VARIANT_SHRED / PARQUET_VARIANT_BUFFER_SIZE /
PARQUET_VARIANT_BUFFER_SIZE_DEFAULT directly? Otherwise we now have two names
for the same thing on the public API surface.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
