dttung2905 commented on code in PR #31:
URL: https://github.com/apache/iceberg-terraform/pull/31#discussion_r3178646241
##########
internal/provider/provider.go:
##########
@@ -44,13 +42,11 @@ func New() func() provider.Provider {
// polarisSettingsModel is the Terraform-facing shape of the nested
polaris_settings block.
type polarisSettingsModel struct {
ManagementURI types.String `tfsdk:"management_uri"`
- CatalogName types.String `tfsdk:"catalog_name"`
}
// polarisConfig holds Polaris-specific runtime configuration derived from
polaris_settings.
type polarisConfig struct {
managementURI string
- catalogName string
Review Comment:
I dropped catalogName from polarisConfig because nothing in this provider
reads it yet. Principal / principal-role management APIs (/principals,
/principal-roles) are defined without a catalog segment in path; Polaris
implements them without a catalog parameter.
Paths that do carry catalogName (e.g.
/catalogs/{catalogName}/catalog-roles/...) should expose catalog_name on the
specific resource or data source that calls those endpoints, not as a generic
default on the provider. That avoids assuming a single catalog when a config
might talk to multiple catalogs over time.
https://editor.swagger.io/?url=https://raw.githubusercontent.com/apache/polaris/refs/heads/main/spec/polaris-management-service.yml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
