kevinjqliu opened a new pull request, #3323:
URL: https://github.com/apache/iceberg-python/pull/3323
<!--
Thanks for opening a pull request!
-->
<!-- In the case this PR will resolve an issue, please replace
${GITHUB_ISSUE_ID} below with the actual Github issue id. -->
<!-- Closes #${GITHUB_ISSUE_ID} -->
# Rationale for this change
Follow up to Python 3.14 support (#3299)
Daft <0.7.10 has a type-checking bug on Python 3.14 where `typing.Union`
became a proper `type`, causing `daft.read_iceberg()` to reject `Table` objects
with `APITypeError`.
In Python 3.14, `typing.Union` is now a class (`isinstance(typing.Union,
type)` → `True`). Daft's `isinstance_helper` checks `isinstance(origin_T,
type)` before `origin_T is Union`, hitting the generic branch instead of
decomposing the union args.
## Are these changes tested?
Yes, tested locally
```
PYTHON=3.14 make install && make test-integration
```
Note, integration tests only run on Python 3.12 in CI, so this wasn't caught
## Are there any user-facing changes?
<!-- In the case of user-facing changes, please add the changelog label. -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
