rambleraptor commented on code in PR #3293:
URL: https://github.com/apache/iceberg-python/pull/3293#discussion_r3171565756
##########
pyiceberg/conversions.py:
##########
@@ -353,13 +352,24 @@ def _(_: PrimitiveType, b: bytes) -> int:
return _LONG_STRUCT.unpack(b)[0]
+@from_bytes.register(LongType)
+def _(_: PrimitiveType, b: bytes) -> int:
+ if len(b) == 4:
Review Comment:
If it's not 8 bytes, it's going to be 4 bytes. I'm not sure what kind of
data would be 5-7 bytes. I changed it nonetheless just to match the Java
implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
