rambleraptor commented on code in PR #3293:
URL: https://github.com/apache/iceberg-python/pull/3293#discussion_r3170899816
##########
pyiceberg/expressions/visitors.py:
##########
@@ -73,6 +75,18 @@
T = TypeVar("T")
+def _from_bytes_with_promotion(field_type: PrimitiveType, b: bytes) -> Any:
Review Comment:
I avoided that originally to allow us to have two separate code paths, but
you've convinced me that's not necessary. Made that change (plus added some
comments)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
