rchowell commented on code in PR #2380:
URL: https://github.com/apache/iceberg-rust/pull/2380#discussion_r3170703011


##########
crates/catalog/sql/src/catalog.rs:
##########
@@ -297,6 +297,24 @@ impl SqlCatalog {
         .await
         .map_err(from_sqlx_error)?;
 
+        // Check if the catalog table has the iceberg_type column, if not, 
it's a V0 schema.
+        let needs_migration = sqlx::query(&format!(

Review Comment:
   Ok, I see and yep agreed a silent migration/modification is not a great 
experience. I'll go for the same behavior as iceberg-java with the flag+debug 
message.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to