blackmwk commented on code in PR #2380:
URL: https://github.com/apache/iceberg-rust/pull/2380#discussion_r3166520538
##########
crates/catalog/sql/src/catalog.rs:
##########
@@ -297,6 +297,24 @@ impl SqlCatalog {
.await
.map_err(from_sqlx_error)?;
+ // Check if the catalog table has the iceberg_type column, if not,
it's a V0 schema.
+ let needs_migration = sqlx::query(&format!(
Review Comment:
I still don't think this is the right behavior to silently upgrade db
schema. Also it's not upgrading silently, it will check a property:
https://github.com/apache/iceberg/blob/b809dcd770d3c10cc6d81b70dc198422749cfa0e/core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java#L246
As with the property name, how about make it similar java version:
`sql.schema-version` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
