nastra commented on code in PR #16160:
URL: https://github.com/apache/iceberg/pull/16160#discussion_r3166265525
##########
core/src/main/java/org/apache/iceberg/rest/RESTSerializers.java:
##########
@@ -273,6 +276,27 @@ public void serialize(
}
}
+ public static class CatalogObjectIdentifierDeserializer
+ extends JsonDeserializer<CatalogObjectIdentifier> {
+ @Override
+ public CatalogObjectIdentifier deserialize(JsonParser p,
DeserializationContext context)
+ throws IOException {
+ String[] levels = JsonUtil.getStringArray(p.getCodec().readTree(p));
Review Comment:
I know it's essentially a one-liner and we do the same for Namespace, but I
wonder if it's worth still creating a separate Parser class. That way we can
independently test the from/to JSON parts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
