adutra commented on code in PR #15703:
URL: https://github.com/apache/iceberg/pull/15703#discussion_r3156161840
##########
build.gradle:
##########
@@ -395,6 +395,13 @@ project(':iceberg-core') {
exclude group: 'org.slf4j', module: 'slf4j-log4j12'
}
+ // OAuth2
+ implementation(libs.nimbus.oauth2.oidc.sdk) {
+ exclude group: 'net.minidev', module: 'accessors-smart'
Review Comment:
These exclusions allow to narrow the amount of transitive dependencies
brought by Nimbus:
- `accessors-smart` is an optional bytecode-generation optimizer for
`json-smart`; `json-smart` falls back to reflection without it. Besides
`accessors-smart` also brings ASM, which is a big jar. Removing these is safe
because Nimbus objects all implement `JSONAware` (i.e. they expose a
`.toJSONString()` method) and thus do not need reflection in order to be
serialized.
- `jcip-annotations` are compile-time thread-safety markers; they can be
safely excluded.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
