mxm commented on code in PR #16126: URL: https://github.com/apache/iceberg/pull/16126#discussion_r3152496651
########## flink/v1.20/flink-runtime/NOTICE: ########## @@ -590,3 +590,15 @@ This product bundles Conscrypt (uber-jar) with the following in its NOTICE: | * licenses/LICENSE.harmony.txt (Apache License 2.0) | * HOMEPAGE: | * https://harmony.apache.org/ + +-------------------------------------------------------------------------------- + +This product bundles Apache Flink Metrics Dropwizard with the following in its NOTICE file: +| Apache Flink +| Copyright 2006-2026 The Apache Software Foundation +| +| This product includes software developed at +| The Apache Software Foundation (http://www.apache.org/). +| +| Flink : Metrics : Dropwizard +| Copyright 2014-2026 The Apache Software Foundation Review Comment: There is the mention of "If the dependency supplies a NOTICE file, its contents must be analyzed and the relevant portions bubbled up into the top-level NOTICE file.", but I agree that the ASF notice does not need to be bubbled up. I've removed this notice. https://infra.apache.org/licensing-howto.html#alv2-dep ########## flink/v1.20/build.gradle: ########## @@ -156,6 +156,7 @@ project(":iceberg-flink:iceberg-flink-runtime-${flinkMajorVersion}") { implementation(project(":iceberg-flink:iceberg-flink-${flinkMajorVersion}")) { exclude group: 'org.apache.flink' } + Review Comment: Removed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
