rdblue commented on code in PR #16126: URL: https://github.com/apache/iceberg/pull/16126#discussion_r3150624093
########## flink/v1.20/flink-runtime/LICENSE: ########## @@ -564,6 +564,14 @@ License: Apache License, Version 2.0 - https://www.apache.org/licenses/LICENSE-2 -------------------------------------------------------------------------------- +This product bundles Apache Flink Metrics Dropwizard. Review Comment: I agree that we want to be more specific about this. It wouldn't be good to say that this "bundles Apache Flink". But the way this is written seems like we're directly converting an artifact name `flink-metrics-dropwizard` into a noun that doesn't quite work. What about "This product bundles Apache Flink's optional support for Dropwizard Metrics"? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
