pvary commented on code in PR #15865:
URL: https://github.com/apache/iceberg/pull/15865#discussion_r3146798249
##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/DataFileRewritePlanner.java:
##########
@@ -73,8 +74,8 @@ public DataFileRewritePlanner(
int newPartialProgressMaxCommits,
long maxRewriteBytes,
Map<String, String> rewriterOptions,
- Expression filter,
- String branch) {
+ String branch,
+ SerializableSupplier<Expression> filterSupplier) {
Review Comment:
Why not just change the type? It is a bit easier to review. Not a big issue,
just asking
```suggestion
SerializableSupplier<Expression> filterSupplier,
String branch) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
