mxm commented on code in PR #15865:
URL: https://github.com/apache/iceberg/pull/15865#discussion_r3146382795
##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/maintenance/api/RewriteDataFiles.java:
##########
@@ -214,9 +215,23 @@ public Builder maxFilesToRewrite(int maxFilesToRewrite) {
*
* @param newFilter the filter expression to apply
* @return this for method chaining
+ * @deprecated will be removed in 1.12.0. Use {@link
#filter(SerializableSupplier)} instead
*/
+ @Deprecated
public Builder filter(Expression newFilter) {
- this.filter = newFilter;
+ this.filterSupplier = () -> newFilter;
Review Comment:
Doesn't this change the semantics of the existing method? Are we ok with
that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
