rambleraptor commented on code in PR #15180:
URL: https://github.com/apache/iceberg/pull/15180#discussion_r3139515811
##########
open-api/rest-catalog-open-api.py:
##########
@@ -1763,6 +1955,15 @@ class ReportMetricsRequest1(ScanReport):
report_type: str = Field(..., alias='report-type')
+class FunctionDataType(
+ RootModel[str | FunctionListType | FunctionMapType | FunctionStructType]
+):
+ root: str | FunctionListType | FunctionMapType | FunctionStructType =
Field(
Review Comment:
nit: Consider having a FunctionPrimitiveType. You can use the `pattern`
field to express a regex for types that aren't a static string.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
