hemanthboyina commented on issue #16083: URL: https://github.com/apache/iceberg/issues/16083#issuecomment-4305376422
Right, as @RussellSpitzer pointed out, TypeUtil.isPromotionAllowed only handles int→long, float→double, and decimal widening today. there's simply no date case in the switch statement, so it always returns false. The other piece is that this method currently doesn't know about the table's format version at all, which it needs since date → timestamp/timestamp_ns is only valid for v3+ tables per the spec. please let me know if I am missing something here. I'd be happy to pick this up and submit a PR if no one else is already working on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
