pvary commented on code in PR #15862:
URL: https://github.com/apache/iceberg/pull/15862#discussion_r3129848268
##########
core/src/main/java/org/apache/iceberg/util/LockManagers.java:
##########
@@ -109,9 +107,9 @@ public int heartbeatThreads() {
}
public ScheduledExecutorService scheduler() {
- if (scheduler == null) {
+ if (scheduler == null || scheduler.isShutdown()) {
Review Comment:
Do we need this change if we don't shut down the scheduler?
##########
core/src/main/java/org/apache/iceberg/util/LockManagers.java:
##########
@@ -109,9 +107,9 @@ public int heartbeatThreads() {
}
public ScheduledExecutorService scheduler() {
- if (scheduler == null) {
+ if (scheduler == null || scheduler.isShutdown()) {
synchronized (BaseLockManager.class) {
- if (scheduler == null) {
+ if (scheduler == null || scheduler.isShutdown()) {
Review Comment:
Do we need this change if we don't shut down the scheduler?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
