RussellSpitzer commented on code in PR #15634:
URL: https://github.com/apache/iceberg/pull/15634#discussion_r3120448552
##########
core/src/main/java/org/apache/iceberg/ManifestWriter.java:
##########
@@ -240,6 +248,18 @@ public ManifestFile toManifestFile() {
firstRowId);
}
+ private ByteBuffer keyMetadataBuffer() {
+ if (keyMetadata instanceof NativeEncryptionKeyMetadata nativeKeyMetadata
Review Comment:
Yeah this is ... a bit unfortunate. It is "native" in terms of Parquet/Avro
but it's also the base container for all of our encryption key metadata classes.
The actual "don't use AES" encryption on write code is
https://github.com/apache/iceberg/pull/15634/changes/BASE..73f5759d3229d45dc7cf3bce6e05129f92eed310#diff-4e8faf21494a38d340335de99357de31cdca2f3f82af495f832f67fc2446ad49R92-R93
Where we cast a StandardEncryptionOutputFile into a
NativeEncryptionOutputFile which strips out the AES encryption.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
