RussellSpitzer commented on code in PR #15634:
URL: https://github.com/apache/iceberg/pull/15634#discussion_r3120385719


##########
core/src/main/java/org/apache/iceberg/ManifestWriter.java:
##########
@@ -65,7 +67,8 @@ private ManifestWriter(
       Long snapshotId,
       Long firstRowId,
       Map<String, String> writerProperties) {
-    this.file = file.encryptingOutputFile();
+    this.format = 
FileFormat.fromFileName(file.encryptingOutputFile().location());

Review Comment:
   I think getting it from the extensions is probably fine for now? Just to 
avoid extending the apis



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to