mbutrovich commented on code in PR #2349:
URL: https://github.com/apache/iceberg-rust/pull/2349#discussion_r3114301718
##########
crates/iceberg/src/arrow/reader.rs:
##########
@@ -301,32 +308,29 @@ impl ArrowReader {
)
};
- Ok(stream)
+ Ok((stream, scan_metrics))
}
+}
- async fn process_file_scan_task(
- task: FileScanTask,
- batch_size: Option<usize>,
- file_io: FileIO,
- delete_file_loader: CachingDeleteFileLoader,
- row_group_filtering_enabled: bool,
- row_selection_enabled: bool,
- parquet_read_options: ParquetReadOptions,
- ) -> Result<ArrowRecordBatchStream> {
+impl FileScanTaskReader {
Review Comment:
Will do!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
