mbutrovich commented on code in PR #2349:
URL: https://github.com/apache/iceberg-rust/pull/2349#discussion_r3114299232
##########
crates/iceberg/src/arrow/reader.rs:
##########
@@ -301,32 +308,29 @@ impl ArrowReader {
)
};
- Ok(stream)
+ Ok((stream, scan_metrics))
}
+}
- async fn process_file_scan_task(
- task: FileScanTask,
- batch_size: Option<usize>,
- file_io: FileIO,
- delete_file_loader: CachingDeleteFileLoader,
- row_group_filtering_enabled: bool,
- row_selection_enabled: bool,
- parquet_read_options: ParquetReadOptions,
- ) -> Result<ArrowRecordBatchStream> {
+impl FileScanTaskReader {
+ async fn process(self, task: FileScanTask) ->
Result<ArrowRecordBatchStream> {
let should_load_page_index =
- (row_selection_enabled && task.predicate.is_some()) ||
!task.deletes.is_empty();
- let mut parquet_read_options = parquet_read_options;
+ (self.row_selection_enabled && task.predicate.is_some()) ||
!task.deletes.is_empty();
+ let mut parquet_read_options = self.parquet_read_options;
parquet_read_options.preload_page_index = should_load_page_index;
- let delete_filter_rx =
- delete_file_loader.load_deletes(&task.deletes,
Arc::clone(&task.schema));
+ let delete_filter_rx = self
+ .delete_file_loader
+ .load_deletes(&task.deletes, Arc::clone(&task.schema));
Review Comment:
I was wondering about that, it seems like Iceberg Java does not lump them
together, but that doesn't mean we should not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
