geruh commented on code in PR #3257:
URL: https://github.com/apache/iceberg-python/pull/3257#discussion_r3112946688


##########
tests/utils/test_manifest.py:
##########
@@ -932,3 +933,43 @@ def test_manifest_writer_tell(format_version: 
TableVersion) -> None:
             after_entry_bytes = writer.tell()
 
             assert after_entry_bytes > initial_bytes, "Bytes should increase 
after adding entry"
+
+
+def test_inherit_from_manifest_snapshot_id() -> None:
+    entry = ManifestEntry.from_args(
+        status=ManifestEntryStatus.ADDED,
+        snapshot_id=None,
+        sequence_number=None,
+        file_sequence_number=None,
+        data_file=DataFile.from_args(

Review Comment:
   Nit: the tests here use the `file_format=FileFormat.PARQUET` for the enum 
and partition is set with `partition=Record()` when constructing a Datafile. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to