lawofcycles opened a new pull request, #3257: URL: https://github.com/apache/iceberg-python/pull/3257
Closes #3256 # Rationale for this change The `snapshot_id` property setter on `ManifestEntry` writes to `self._data[0]` (the `status` field) instead of `self._data[1]` (the `snapshot_id` field). This means that when `_inherit_from_manifest()` assigns a null `snapshot_id` from the manifest's `added_snapshot_id`, the entry's `status` is corrupted and `snapshot_id` remains `None`. ## Are these changes tested? Yes. Added `test_inherit_from_manifest_snapshot_id` to verify that `_inherit_from_manifest()` correctly inherits `snapshot_id` without corrupting the `status` field. ## Are there any user-facing changes? N/A -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
