drexler-sky commented on PR #16006:
URL: https://github.com/apache/iceberg/pull/16006#issuecomment-4272488701
Thanks @pvary @anoopj — agreed, the blanket rejection was too aggressive.
I've updated the PR to mirror `BaseParquetReaders` exactly:
- uint8 / uint16 → IntegerType: accepted (lossless, same IntVector path — no
perf cost)
- uint32 → IntegerType: rejected with IllegalArgumentException("Cannot read
UINT32 as an int value")
- uint64 → LongType: rejected with IllegalArgumentException("Cannot read
UINT64 as a long value")
Tests updated accordingly: dropped uint8/uint16 from the rejection matrix,
and added a positive test that round-trips uint8=250 / uint16=50000.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
