huaxingao commented on PR #16006: URL: https://github.com/apache/iceberg/pull/16006#issuecomment-4321332863
@pvary the PR was updated to mirror BaseParquetReaders's rejection policy: uint8/uint16 are now accepted and uint32/uint64 are rejected with the same IllegalArgumentException messages as the non-vectorized path. The one remaining gap vs the non-vectorized reader is uint32 → long widening (the expected.typeId() == TypeID.LONG branch in BaseParquetReaders), which would require a new vectorized read path and is worth a separate PR. Do you have any further concerns? If not, I'll merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
