psvri commented on code in PR #15906:
URL: https://github.com/apache/iceberg/pull/15906#discussion_r3098516753
##########
data/src/test/java/org/apache/iceberg/data/BaseFormatModelTests.java:
##########
@@ -628,6 +644,239 @@ void
testReaderBuilderRecordsPerBatchNotSupported(FileFormat fileFormat) throws
.isInstanceOf(UnsupportedOperationException.class);
}
+ @ParameterizedTest
Review Comment:
Looking at the iceberg spec , I feel its better to have the below tests as
well as part of the TCK.
- We should have tests for NAN value counts.
- We should have test where appropriate metrics enabled for double/float
column containing nan's will populate NAN value counts ,lower and upper bounds.
- We should have tests where for double/float column, the lower and upper
bounds computed will be in accordance with iceberg sorting logic defined in the
[spec](https://iceberg.apache.org/spec/#sorting) `-NaN < -Infinity < -value <
-0 < 0 < value < Infinity < NaN` .
- We should have tests with truncate metrics mode
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
