pvary commented on code in PR #15906:
URL: https://github.com/apache/iceberg/pull/15906#discussion_r3093094190
##########
data/src/test/java/org/apache/iceberg/data/BaseFormatModelTests.java:
##########
@@ -719,4 +981,120 @@ private static String splitSizeProperty(FileFormat
fileFormat) {
"No split size property defined for format: " + fileFormat);
};
}
+
+ private void assertValueAndNullCounts(
Review Comment:
make sure that the methods which could be static are static.
Maybe check other methods as well, and fix when possible. If they are too
many of them, please create a separate PR for it. I have forgotten to check
them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
