xanderbailey commented on code in PR #2337:
URL: https://github.com/apache/iceberg-rust/pull/2337#discussion_r3091833556
##########
crates/iceberg/src/scan/context.rs:
##########
@@ -33,6 +33,14 @@ use crate::spec::{
};
use crate::{Error, ErrorKind, Result};
+/// Filter applied to each [`ManifestFile`] before fetching it.
+/// Returns `true` to include the manifest, `false` to skip it.
+pub(crate) type ManifestFileFilter = Arc<dyn Fn(&ManifestFile) -> bool + Send
+ Sync>;
+
+/// Filter applied to each manifest entry after loading a manifest.
+/// Returns `true` to include the entry, `false` to skip it.
+pub(crate) type ManifestEntryFilter = Arc<dyn Fn(&ManifestEntryRef) -> bool +
Send + Sync>;
+
Review Comment:
I think this is a nice way to inject these filters and should extend to
other future scans
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
