gaborkaszab commented on code in PR #15968:
URL: https://github.com/apache/iceberg/pull/15968#discussion_r3086979982
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##########
@@ -824,11 +832,7 @@ protected Map<String, String> properties() {
@Override
public void close() throws IOException {
- super.close();
Review Comment:
You're right, and thanks for the pointer!
Closing `MetricsReporter` in the derived catalogs seems intentional then. I
still think that the level of abstraction for that is the
`BaseMetastoreCatalog` and each level should be responsible to clean up
whatever they introduce. If they don't then this is what happens: each
implementation has to clean up for whatever the base class doesn't clean up.
This is exactly what we see in these derived classes.
I'm in favor of revising what we have and calling `super.close()` for each
of these implementations rather than closing `MetricsReporter` themselves.
@nastra, @amogh-jahagirdar you were involved initially, WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
