gaborkaszab commented on code in PR #15968:
URL: https://github.com/apache/iceberg/pull/15968#discussion_r3086572950
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##########
@@ -824,11 +832,7 @@ protected Map<String, String> properties() {
@Override
public void close() throws IOException {
- super.close();
Review Comment:
metrics reporter is created on another level (`BaseMetastoreCatalog`), I
think that level should be responsible of closing it. Calling `super.close()`
here makes sense because it is future proof, whatever the parent class want to
close it can. We can't take their responsibility here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
