ebyhr commented on code in PR #15973:
URL: https://github.com/apache/iceberg/pull/15973#discussion_r3082953143
##########
parquet/src/main/java/org/apache/iceberg/parquet/ParquetIO.java:
##########
@@ -181,24 +180,22 @@ public void readVectored(List<ParquetFileRange> ranges,
ByteBufferAllocator allo
delegate.readVectored(delegateRange, allocate::allocate);
}
+ /**
+ * convert parquet file ranges to iceberg file range.
+ *
+ * @param ranges input parquet file range.
+ * @return iceberg file range list.
+ */
Review Comment:
nit: I don't see much value in having javadoc for this simple private helper
method.
##########
api/src/main/java/org/apache/iceberg/io/FileRange.java:
##########
@@ -28,8 +27,7 @@ public class FileRange {
private final long offset;
private final int length;
- public FileRange(CompletableFuture<ByteBuffer> byteBuffer, long offset, int
length)
- throws EOFException {
+ public FileRange(CompletableFuture<ByteBuffer> byteBuffer, long offset, int
length) {
Review Comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
