nastra commented on PR #15919: URL: https://github.com/apache/iceberg/pull/15919#issuecomment-4245270209
> project convention recommends package-private visibility unless broader access is required This is true for production code because of API stability but we don't use this convention for test classes and methods, hence I'm not a fan of changing this because we're also not enforcing this across the project -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
