pvary commented on code in PR #15180:
URL: https://github.com/apache/iceberg/pull/15180#discussion_r3080729679
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -2228,6 +2321,18 @@ components:
type: string
nullable: false
+ FunctionIdentifier:
Review Comment:
I think that `FunctionIdentifier` could extend `CatalogObjectIdentifier` in
the java code, for example:
```
FunctionIdentifier extends CatalogObjectIdentifier {
FunctionIdentifier() {
super(IdentifierType.FUNCTION);
}
}
```
That said, this may not be something we want to expose through the REST API.
`ListFunctionsResponse` already includes the namespace and the function name,
and it probably doesn’t need to repeat that each entry is a `FUNCTION`.
`CatalogObjectIdentifier` makes sense in the context of the batch reader
API, where we request different kinds of catalog objects. For listing
functions, however, I’m not sure it adds much value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
