mxm commented on code in PR #14848: URL: https://github.com/apache/iceberg/pull/14848#discussion_r3079540114
########## flink/v2.1/flink-runtime/LICENSE: ########## @@ -614,6 +614,35 @@ License: BSD 2-Clause -------------------------------------------------------------------------------- +This binary artifact contains Azure Security Key Vault Keys. Review Comment: `azure-security-keyvault-keys` is `compileOnly` in `iceberg-azure`: https://github.com/apache/iceberg/blob/87c743463b6311f2412e1addf19cf204c1b79e3d/build.gradle#L599 Thus, it should not end up on the runtime classpath which is the basis for the shadow jar built in `flink-runtime`. You can verify with: ``` ./gradlew :iceberg-flink:iceberg-flink-runtime-2.1:dependencies --configuration runtimeClasspath ``` The library is only bundled in `iceberg-azure-bundle`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
