danielcweeks commented on code in PR #15581:
URL: https://github.com/apache/iceberg/pull/15581#discussion_r3076084396
##########
aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIO.java:
##########
@@ -427,14 +448,11 @@ private Map<String, PrefixedS3Client> clientByPrefix() {
return clientByPrefix;
}
- private ExecutorService executorService() {
+ private ExecutorService executorService(String name, int size) {
Review Comment:
Also, the executor service was recently changed due accommodate credential
refresh scheduling, so the service is now more generic, but currently based on
the delete threads property. We can probably update this to be more generic
along with a more general io threads property. Alternatively, we could have a
separate static service explicitly for the S3InputStream, which might be
preferable to overloading the FileIO service for multiple operations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
