danielcweeks commented on code in PR #15581:
URL: https://github.com/apache/iceberg/pull/15581#discussion_r3075842388
##########
aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIO.java:
##########
@@ -427,14 +448,11 @@ private Map<String, PrefixedS3Client> clientByPrefix() {
return clientByPrefix;
}
- private ExecutorService executorService() {
+ private ExecutorService executorService(String name, int size) {
Review Comment:
This change doesn't really work since it's a static initialization but
you're also setting a name/size. Basically, the first one wins? This isn't
really a workable update to handling the executor service.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
