zeroshade commented on PR #880: URL: https://github.com/apache/iceberg-go/pull/880#issuecomment-4239026551
> For the tests, I thought a bitand came up with two ways to go about it - > 1. we maintain another field-type mapping in tests that serves as the source of truth and can be compared against > in the tests > 2. we save binary snapshots (or JSON of it) in the repo itself that we can assert against after generating avro from > our code. Prone to break in future if we add fields, but that's what tests should do. I think it would be sufficient to just have a test which writes out the avro file and then reads it back and asserts the field is int and not long. Avro files are self-describing and have their schema as a metadata key so it should be possible to do. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
