rohilsurana commented on PR #880: URL: https://github.com/apache/iceberg-go/pull/880#issuecomment-4238960613
Added a note that older manifests will need to be migrated. Should we provide a way for doing that? For the tests, I thought a bitand came up with two ways to go about it - - we maintain another field-type mapping in tests that serves as the source of truth and can be compared against in the tests - we save binary snapshots (or JSON of it) in the repo itself that we can assert against after generating avro from our code. Prone to break in future if we add fields, but that's what tests should do. I would love to understand your take on this. Which would be the better approach here or if there is other way that you could suggest. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
