huaxingao commented on code in PR #15180:
URL: https://github.com/apache/iceberg/pull/15180#discussion_r3019020915


##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -2228,6 +2321,18 @@ components:
           type: string
           nullable: false
 
+    FunctionIdentifier:

Review Comment:
   Thanks for the suggestion! I prefer to keep `FunctionIdentifier` for now. 
After we have a discussion on C`atalogObjectIdentifier` and reach consensus, 
I'll have a follow-up PR to rename both `ableIdentifier` and 
`FunctionIdentifier`.



##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -4184,6 +4300,278 @@ components:
           items:
             $ref: '#/components/schemas/Namespace'
 
+    LoadFunctionResult:
+      description: |
+        Result returned when a function is loaded from the catalog.
+
+
+        The function metadata JSON is returned in the `metadata` field. The 
location of the metadata
+        file is returned in the `metadata-location` field, if available.
+      type: object
+      required:
+        - metadata
+      properties:
+        metadata-location:
+          type: string
+        metadata:
+          $ref: '#/components/schemas/UdfMetadata'
+
+    UdfMetadata:

Review Comment:
   Fixed. Thanks



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to