stevenzwu commented on code in PR #15180:
URL: https://github.com/apache/iceberg/pull/15180#discussion_r3018382684
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -2228,6 +2321,18 @@ components:
type: string
nullable: false
+ FunctionIdentifier:
Review Comment:
I am wondering if we should change this more generic
`CatalogObjectIdentifier`. I thought about [introducing it in the single and
batch load endpoints for relational
objects](https://docs.google.com/document/d/1VW5hgaaajRWtp5KbOU3s83YyoyPi5WOSvHtoJ_yXzJs/edit?tab=t.nc5mpd3ozmp3#heading=h.2l1lvcoezaiz).
But I decided that it is not needed for the relational objects proposal, where
we can just using the `TableIdentifier`.
I also comment this while reviewing the [events endpoint Java impl
PR](https://github.com/apache/iceberg/pull/14142/changes#r2919802280).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]