nastra commented on code in PR #15461:
URL: https://github.com/apache/iceberg/pull/15461#discussion_r2894250786
##########
api/src/main/java/org/apache/iceberg/Scan.java:
##########
@@ -208,4 +209,13 @@ default ThisT minRowsRequested(long numRows) {
throw new UnsupportedOperationException(
this.getClass().getName() + " doesn't implement minRowsRequested");
}
+
+ /**
+ * The {@link FileIO} instance to use when reading data
+ *
+ * @return the {@link FileIO} instance to use when reading data
+ */
+ default FileIO io() {
+ throw new UnsupportedOperationException(this.getClass().getName() + "
doesn't implement io");
Review Comment:
I'm in favor of changing the message here since it makes it actually clearer
when the default method was added. However, we are basically using this error
msg pattern across the codebase when throwing an UOE on default methods, so
should we be using the new error msg pattern in newly added code as well maybe?
I think that would be a good idea (we should then probably also update our docs
around this)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
