rdblue commented on code in PR #15461:
URL: https://github.com/apache/iceberg/pull/15461#discussion_r2893126167
##########
api/src/main/java/org/apache/iceberg/Scan.java:
##########
@@ -208,4 +209,13 @@ default ThisT minRowsRequested(long numRows) {
throw new UnsupportedOperationException(
this.getClass().getName() + " doesn't implement minRowsRequested");
}
+
+ /**
+ * The {@link FileIO} instance to use when reading data
+ *
+ * @return the {@link FileIO} instance to use when reading data
+ */
+ default FileIO io() {
+ throw new UnsupportedOperationException(this.getClass().getName() + "
doesn't implement io");
Review Comment:
I don't think this message is very helpful. It doesn't provide any
information about why `io` is missing. What about this instead?
"io() is not implemented: added in 1.11.0"
I also don't think that it is useful to print internal class names and that
it is more clear to add parens so that it is read as the `io` function and not
I/O in general.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
